netdev - Re: [PATCH net v3] bonding: add ip checks when store ip target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131114.165516.863952218326737474.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 16:55:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, andy@...yhouse.net, nikolay@...hat.com,
	vfalico@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v3] bonding: add ip checks when store ip target

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Thu, 14 Nov 2013 19:02:42 +0800

>  	targets = bond->params.arp_targets;
> -	newtarget = in_aton(buf + 1);
> +	if (!in4_pton(buf + 1, -1, (u8 *)&newtarget, -1, NULL) ||
> +			IS_IP_TARGET_UNUSABLE_ADDRESS(newtarget)) {

This is not indented correctly.

On the second line, the IS_IP_TARGET... should start at the very
first column after the openning parenthesis on the previous line.

If you are using only TAB characters to indent, rather than an
appropriate mix of TAB and SPACE characters, you are doing it
wrong.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html