netdev - Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131115.205414.2167691852332909992.davem@davemloft.net>
Date:	Fri, 15 Nov 2013 20:54:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, linux-wimax@...el.com,
	bsingharora@...il.com, netfilter-devel@...r.kernel.org,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com
Subject: Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)

From: Johannes Berg <johannes@...solutions.net>
Date: Fri, 15 Nov 2013 14:23:14 +0100

> On Fri, 2013-11-15 at 14:18 +0100, Johannes Berg wrote:
> 
>> I've been eyeing the multicast groups as well
> 
> Of course, there are also *much* fewer mcast groups, so the saving isn't
> nearly as big. But we still have some oddball code to register them all,
> basically
> 
> 	err = register_mc_group();
> 	if (err)
> 		goto unregister_family;
> 
> (since we have to register the family first, afaict)
> 
> sometimes a few of those back to back, and it'd be nicer on the users if
> that just went away and was
> 
> 	family.mcast_groups = my_groups;
> 	family.n_mcast_groups = ARRAY_SIZE(my_groups);
> 	family.ops = my_ops;
> 	family.n_ops = ARRAY_SIZE(my_ops);
> 	return genl_register_family(&family);
> 
> since nobody uses them dynamically anyway, afaict.

See my other email:

#define genl_register_family_with_ops_mcast(family, ops, groups) \
	__genl_register_family(family, ops, ARRAY_SIZE(ops), groups, ARRAY_SIZE(groups))

you get the idea.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html