netdev - Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1384679524.14795.7.camel@jlt4.sipsolutions.net>
Date:	Sun, 17 Nov 2013 10:12:04 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-wimax@...el.com,
	bsingharora@...il.com, netfilter-devel@...r.kernel.org,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com
Subject: Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)

On Fri, 2013-11-15 at 20:53 -0500, David Miller wrote:

> > We could instead register an array of pointers to the groups:
> > 
> > static const struct mcast_group *my_groups[] = {
> >       &my_foo_mcast_group,
> >       ...
> > };
> > 
> > and pass this to the family - that'd still be less space (one pointer
> > for each group rather than two in a linked list) and still allow all
> > groups and this array to be const, but it's not quite as big a
> > saving ...
> > 
> > Thoughts?
> 
> This idea sounds fine.  I don't even thing the array indexing is
> odd, especially if we can have named mnenomics for the indices
> or similar.

I posted something yesterday, but forgot to reply here - basically as
you'll see in the patches, I decided that we should pass the
family/group array index instead of passing the global group identifier
- this will also prevent new users of the APIs from abusing them like
quota/dropmonitor unfortunately did.

johannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html