netdev - Re: [PATCH] net: Fix ehea warning when built in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131121.130754.2206370935570985768.davem@davemloft.net>
Date:	Thu, 21 Nov 2013 13:07:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mikey@...ling.org
Cc:	jeffm@...e.com, ohering@...e.com, jslaby@...e.cz,
	netdev@...r.kernel.org, cascardo@...ux.vnet.ibm.com
Subject: Re: [PATCH] net: Fix ehea warning when built in

From: Michael Neuling <mikey@...ling.org>
Date: Thu, 21 Nov 2013 15:36:49 +1100

> In:
>   commit 7a3a62128388a6af771e99df8628ddee2e8be7ca
>   Author: Olaf Hering <ohering@...e.com>
>   drivers/net/ethernet/ibm/ehea/ehea_main.c: add alias entry for portN properties
> We added ehea_module_device_table.  Unfortunately we only use this when
> building as a module so we get the following warning when built in, like
> in pseries_defconfig:
> 
>   drivers/net/ethernet/ibm/ehea/ehea_main.c:105:1: warning: 'ehea_module_device_table' defined but not used [-Wunused-variable]
> 
> This wraps ehea_module_device_table with #if MODULE.
> 
> Signed-off-by: Michael Neuling <mikey@...ling.org>

I think putting an ugly MODULE ifdef into every driver that does something
like this is not going to cut it.

Rather, the MODULE_DEVICE_TABLE() definition when !MODULE should do something
reasonable, like make a void reference to the symbole.

I'm not applying this, the fix belongs in a generic place.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html