netdev - [PATCH] net: Fix ehea warning when built in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <11586.1385008609@ale.ozlabs.ibm.com>
Date:	Thu, 21 Nov 2013 15:36:49 +1100
From:	Michael Neuling <mikey@...ling.org>
To:	Jeff Mahoney <jeffm@...e.com>, Olaf Hering <ohering@...e.com>,
	Jiri Slaby <jslaby@...e.cz>
cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
Subject: [PATCH] net: Fix ehea warning when built in

In:
  commit 7a3a62128388a6af771e99df8628ddee2e8be7ca
  Author: Olaf Hering <ohering@...e.com>
  drivers/net/ethernet/ibm/ehea/ehea_main.c: add alias entry for portN properties
We added ehea_module_device_table.  Unfortunately we only use this when
building as a module so we get the following warning when built in, like
in pseries_defconfig:

  drivers/net/ethernet/ibm/ehea/ehea_main.c:105:1: warning: 'ehea_module_device_table' defined but not used [-Wunused-variable]

This wraps ehea_module_device_table with #if MODULE.

Signed-off-by: Michael Neuling <mikey@...ling.org>

diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 2d1c6bd..a17a1d1 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -102,6 +102,7 @@ static int ehea_probe_adapter(struct platform_device *dev);
 
 static int ehea_remove(struct platform_device *dev);
 
+#ifdef MODULE
 static struct of_device_id ehea_module_device_table[] = {
 	{
 		.name = "lhea",
@@ -114,6 +115,7 @@ static struct of_device_id ehea_module_device_table[] = {
 	{},
 };
 MODULE_DEVICE_TABLE(of, ehea_module_device_table);
+#endif
 
 static struct of_device_id ehea_device_table[] = {
 	{
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html