netdev - Re: [PATCH linux-next] hisax: disable build for big-endian arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hzjowhp2l.wl%tiwai@suse.de>
Date:	Fri, 22 Nov 2013 08:29:22 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org, Karsten Keil <isdn@...ux-pingi.de>
Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm

At Fri, 22 Nov 2013 00:49:54 +0100,
Vincent Stehlé wrote:
> 
> Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in
> Kconfig.
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> ---
> 
> Hi,
> 
> This can be seen on e.g. linux next-20131121 with arm allyesconfig.
> 
> Best regards,
> 
> V.
> 
>  drivers/isdn/hisax/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
> index d9edcc9..53dbb75 100644
> --- a/drivers/isdn/hisax/Kconfig
> +++ b/drivers/isdn/hisax/Kconfig
> @@ -109,7 +109,7 @@ config HISAX_16_3
>  
>  config HISAX_TELESPCI
>  	bool "Teles PCI"
> -	depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> +	depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN)))

Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally?

	depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM))

Or maybe just

	depends on PCI && (X86 || BROKEN)

(Alpha?  Can anyone test? :)


Takashi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html