netdev - Re: [lm-sensors] [PATCH 5/5] ixgbe: Start temperature sensor attribute index with 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131125180842.GB20159@roeck-us.net>
Date:	Mon, 25 Nov 2013 10:08:42 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	netdev@...r.kernel.org, Nithin Nayak Sujir <nsujir@...adcom.com>,
	e1000-devel@...ts.sourceforge.net,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	lm-sensors@...sensors.org, Greg Rose <gregory.v.rose@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Michael Chan <mchan@...adcom.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [lm-sensors] [PATCH 5/5] ixgbe: Start temperature sensor
 attribute  index with 1

On Sat, Nov 23, 2013 at 02:01:58PM +0100, Jean Delvare wrote:
> On Fri, 22 Nov 2013 22:08:01 -0800, Guenter Roeck wrote:
> > Per hwmon ABI, temperature sensor attribute index starts with 1, not 0.
> > 
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c
> > index 3081974..e74ae36 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c
> > @@ -118,22 +118,22 @@ static int ixgbe_add_hwmon_attr(struct ixgbe_adapter *adapter,
> >  	case IXGBE_HWMON_TYPE_LOC:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_location;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_label", offset);
> > +			 "temp%u_label", offset + 1);
> >  		break;
> >  	case IXGBE_HWMON_TYPE_TEMP:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_temp;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_input", offset);
> > +			 "temp%u_input", offset + 1);
> >  		break;
> >  	case IXGBE_HWMON_TYPE_CAUTION:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_cautionthresh;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_max", offset);
> > +			 "temp%u_max", offset + 1);
> >  		break;
> >  	case IXGBE_HWMON_TYPE_MAX:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_maxopthresh;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_crit", offset);
> > +			 "temp%u_crit", offset + 1);
> >  		break;
> >  	default:
> >  		rc = -EPERM;
> 
> Reviewed-by: Jean Delvare <khali@...ux-fr.org>
> 
Hi Jean,

thanks a lot for the reviews!

Guenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html