netdev - Re: [lm-sensors] [PATCH 0/5] net: hwmon fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385405786.1586.44.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 25 Nov 2013 18:56:26 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Guenter Roeck <linux@...ck-us.net>,
	Nithin Nayak Sujir <nsujir@...adcom.com>,
	<e1000-devel@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
	Michael Chan <mchan@...adcom.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	<lm-sensors@...sensors.org>, Greg Rose <gregory.v.rose@...el.com>,
	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [lm-sensors] [PATCH 0/5] net: hwmon fixes

On Mon, 2013-11-25 at 19:23 +0100, Jean Delvare wrote:
> On Mon, 25 Nov 2013 17:15:50 +0000, Ben Hutchings wrote:
> > On Sat, 2013-11-23 at 09:07 -0800, Guenter Roeck wrote:
> > > Yes, I know about that one. It concluded that it would be too invasive
> > > and risky to try to fix it without access to hardware to test the results.
> > > That is why I said "fixes _most_ of the problems".
> > > 
> > > As for why the attributes are created after registration, it was most likely
> > > because there was no API available to attach the sysfs attributes to
> > > the hwmon device in a clean way. The new APIs fix that.
> > 
> > We don't attach them to the hwmon device either, and I would rather not
> > change that yet because lm-sensors 2 is still widely used.
> 
> Mouahahahah.
> 
> No, seriously, it's not.

RHEL 5 has it, and that is widely used - even with recent mainline
kernels, in some cases.

> And lm-sensors 2 doesn't even support your
> device so this is a totally moot point.

I thought it did work with arbitrary devices providing the right
attributes, but obviously I misremembered.  So there's no reason not to
change.  Thanks.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html