netdev - Re: [PATCH net] netem: fix loss generators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131127212849.GA1428@virgo.local>
Date:	Wed, 27 Nov 2013 22:28:50 +0100
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	David Miller <davem@...emloft.net>, stefano.salsano@...roma2.it,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] netem: fix loss generators

* Stephen Hemminger | 2013-11-21 17:54:19 [-0800]:

>Patch from developers of the alternative loss models, downloaded from:
>   http://netgroup.uniroma2.it/twiki/bin/view.cgi/Main/NetemCLG
>
>We found some bugs in our first implementation.
>A first set of bugs is in the function loss_4state:
>   In the case 1 of the switch statement in the if conditions we
>    need to add clg->a4 to clg->a1, according to the model.
>   In the case 3 of the switch statement we need to delete "return
>    true" if the condition leads us in the state 1, because the state 1 is
>    a good state.

I already fixed the former bug[1]. I cc'ed stefano.salsano@...roma2.it but did
not get any acked-by/tested-by. The second bug still exists.

Hagen

[1] http://www.spinics.net/lists/netdev/msg255165.html

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)