netdev - Re: [PATCH net] netem: fix loss generators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131128.181813.1984270468860720177.davem@davemloft.net>
Date:	Thu, 28 Nov 2013 18:18:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	stefano.salsano@...roma2.it, netdev@...r.kernel.org
Subject: Re: [PATCH net] netem: fix loss generators

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 21 Nov 2013 17:54:19 -0800

> Patch from developers of the alternative loss models, downloaded from:
>    http://netgroup.uniroma2.it/twiki/bin/view.cgi/Main/NetemCLG
> 
> We found some bugs in our first implementation.
> A first set of bugs is in the function loss_4state:
>    In the case 1 of the switch statement in the if conditions we
>     need to add clg->a4 to clg->a1, according to the model.
>    In the case 3 of the switch statement we need to delete "return
>     true" if the condition leads us in the state 1, because the state 1 is
>     a good state.
> 
> A second set of bugs is in the function loss_gilb_ell
>   In both cases of the switch statement we need to add the break
>     statement, because the two cases are mutually exclusive.
>   In the case 2, of the switch we change the direction of the inequality to
>     net_random()>clg->a3, because clg->a3 is h in the GE model and when h
>     is 0 all packets will be lost.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Stephen, can you adjust this patch to take into account commit:

4a3ad7b3eade08ad1c760aaa4fe06a36f2584939

as Hagen noted?

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html