netdev - Re: [RFC PATCH v2] diag: warn about missing first netlink attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131128.181654.469352290882758065.davem@davemloft.net>
Date:	Thu, 28 Nov 2013 18:16:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH v2] diag: warn about missing first netlink attribute

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 28 Nov 2013 22:09:09 +0000

> On 11/28/13 at 06:31pm, Nicolas Dichtel wrote:
>> The first netlink attribute (value 0) must always be defined as none/unspec.
>> This is correctly done in inet_diag.h, but other diag interfaces are wrong.
>> 
>> Because we cannot change an existing API, I add a comment to point the mistake
>> and avoid to propagate it in a new diag API in the future.
>> 
>> CC: Thomas Graf <tgraf@...g.ch>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>> ---
>> 
>> v2: just warn about the missing attribute
>> 
>> If patch is approved, I will submit it when the net-next tree opens.
> 
> Acked-by: Thomas Graf <tgraf@...g.ch>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html