netdev - RE: [PATCH net] r8169: check ALDPS bit and disable it if enabled for the 8168g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <103D217663F345E1877FB05AC93E3CFF@realtek.com.tw>
Date:	Thu, 28 Nov 2013 11:37:18 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'David Chang' <dchang@...e.com>, <netdev@...r.kernel.org>
CC:	"'David S. Miller'" <davem@...emloft.net>,
	'Francois Romieu' <romieu@...zoreil.com>, <jlee@...e.com>,
	'nic_swsd' <nic_swsd@...ltek.com>
Subject: RE: [PATCH net] r8169: check ALDPS bit and disable it if enabled for the 8168g

 David Chang [mailto:dchang@...e.com] 
> Sent: Wednesday, November 27, 2013 3:49 PM
> To: netdev@...r.kernel.org
> Cc: David S. Miller; Francois Romieu; Hayeswang; jlee@...e.com
> Subject: [PATCH net] r8169: check ALDPS bit and disable it if 
> enabled for the 8168g
> 
[...]
> +	/* Check ALDPS bit, disable it if enabled */
> +	rtl_writephy(tp, 0x1f, 0x0a43);
> +	if (rtl_readphy(tp, 0x10) & 0x0004)
> +		rtl_w1w0_phy(tp, 0x10, 0x0000, 0x0004);
> +

You have to delay at least 10 ms after disable it.
This makes sure the hw completes the action.
 
Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html