netdev - Re: [PATCH net] r8169: check ALDPS bit and disable it if enabled for the 8168g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128042904.GA9297@linux-g7tt.site>
Date:	Thu, 28 Nov 2013 12:29:04 +0800
From:	David Chang <dchang@...e.com>
To:	hayeswang <hayeswang@...ltek.com>
Cc:	netdev@...r.kernel.org, "'David S. Miller'" <davem@...emloft.net>,
	'Francois Romieu' <romieu@...zoreil.com>, jlee@...e.com,
	'nic_swsd' <nic_swsd@...ltek.com>
Subject: Re: [PATCH net] r8169: check ALDPS bit and disable it if enabled for
 the 8168g

On Thu, Nov 28, 2013 at 11:37:18AM +0800, hayeswang wrote:
>  David Chang [mailto:dchang@...e.com] 
> > Sent: Wednesday, November 27, 2013 3:49 PM
> > To: netdev@...r.kernel.org
> > Cc: David S. Miller; Francois Romieu; Hayeswang; jlee@...e.com
> > Subject: [PATCH net] r8169: check ALDPS bit and disable it if 
> > enabled for the 8168g
> > 
> [...]
> > +	/* Check ALDPS bit, disable it if enabled */
> > +	rtl_writephy(tp, 0x1f, 0x0a43);
> > +	if (rtl_readphy(tp, 0x10) & 0x0004)
> > +		rtl_w1w0_phy(tp, 0x10, 0x0000, 0x0004);
> > +
> 
> You have to delay at least 10 ms after disable it.
> This makes sure the hw completes the action.
>  

Thanks for your comment. 
I'd add a delay time and send the v2 version.

Regards,
David

> Best Regards,
> Hayes
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html