netdev - Re: [PATCH 3/3] xfrm: Fix null pointer dereference when decoding sessions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131201.203506.1790384137281236147.davem@davemloft.net>
Date:	Sun, 01 Dec 2013 20:35:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mschiffer@...verse-factory.net
Cc:	steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] xfrm: Fix null pointer dereference when decoding
 sessions

From: Matthias Schiffer <mschiffer@...verse-factory.net>
Date: Sun, 01 Dec 2013 05:19:53 +0100

> On 11/24/2013 03:27 PM, Matthias Schiffer wrote:
>> On 11/01/2013 09:21 AM, Steffen Klassert wrote:
>>> On some codepaths the skb does not have a dst entry
>>> when xfrm_decode_session() is called. So check for
>>> a valid skb_dst() before dereferencing the device
>>> interface index. We use 0 as the device index if
>>> there is no valid skb_dst(), or at reverse decoding
>>> we use skb_iif as device interface index.
>>>
>>> Bug was introduced with git commit bafd4bd4dc
>>> ("xfrm: Decode sessions with output interface.").
>>>
>>> Reported-by: Meelis Roos <mroos@...ux.ee>
>>> Tested-by: Meelis Roos <mroos@...ux.ee>
>>> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
>> 
>> Please queue this for 3.12-stable, I've seen this bug trigger a panic
>> when heavily using Bittorrent (screenshot:
>> http://i.imgur.com/OIKVccM.jpg )
>> 
>> Thanks,
>> Matthias
>> 
> 
> Ping? Several people I know have hit this panic with 3.12.x at least
> once or twice by now during heavy IPv6 usage.

Steffen submitted it to stable@...r.kernel.org for inclusion on Monday
November 25th.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html