netdev - Re: [PATCH 3/3] xfrm: Fix null pointer dereference when decoding sessions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131203095645.GS31491@secunet.com>
Date:	Tue, 3 Dec 2013 10:56:45 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	David Miller <davem@...emloft.net>
Cc:	mschiffer@...verse-factory.net, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 3/3] xfrm: Fix null pointer dereference when decoding
 sessions

Ccing stable.

On Sun, Dec 01, 2013 at 08:35:06PM -0500, David Miller wrote:
> From: Matthias Schiffer <mschiffer@...verse-factory.net>
> Date: Sun, 01 Dec 2013 05:19:53 +0100
> 
> > On 11/24/2013 03:27 PM, Matthias Schiffer wrote:
> >> On 11/01/2013 09:21 AM, Steffen Klassert wrote:
> >>> On some codepaths the skb does not have a dst entry
> >>> when xfrm_decode_session() is called. So check for
> >>> a valid skb_dst() before dereferencing the device
> >>> interface index. We use 0 as the device index if
> >>> there is no valid skb_dst(), or at reverse decoding
> >>> we use skb_iif as device interface index.
> >>>
> >>> Bug was introduced with git commit bafd4bd4dc
> >>> ("xfrm: Decode sessions with output interface.").
> >>>
> >>> Reported-by: Meelis Roos <mroos@...ux.ee>
> >>> Tested-by: Meelis Roos <mroos@...ux.ee>
> >>> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> >> 
> >> Please queue this for 3.12-stable, I've seen this bug trigger a panic
> >> when heavily using Bittorrent (screenshot:
> >> http://i.imgur.com/OIKVccM.jpg )
> >> 
> >> Thanks,
> >> Matthias
> >> 
> > 
> > Ping? Several people I know have hit this panic with 3.12.x at least
> > once or twice by now during heavy IPv6 usage.
> 
> Steffen submitted it to stable@...r.kernel.org for inclusion on Monday
> November 25th.

It apparently did not make it into v3.12.2 and it is not in the v3.12.3
review included. So I wonder if I need to do anything additional to
get it included. It is the first time that I did a stable submission
myself.

I tried to follow the instructions at Documentation/stable_kernel_rules.txt
but maybe I've missed something.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html