netdev - Re: [PATCH] macvlan: Support creating macvtaps from macvlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEQCv+aM6_SYR1-igsHXmBgxOMsQwBAFNrYe6_VxMEEH62xg3A@mail.gmail.com>
Date:	Tue, 3 Dec 2013 01:58:37 -0800
From:	Kevin Wallace <kevin@...tabarf.net>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] macvlan: Support creating macvtaps from macvlans

Good call; I didn't see those.  I'll grab a more recent snapshot that
includes those helpers, and send out a v2 once I've tested.

Thanks!

Kevin

On Tue, Dec 3, 2013 at 12:24 AM, Michal Kubecek <mkubecek@...e.cz> wrote:
> On Mon, Dec 02, 2013 at 08:13:11PM -0800, Kevin Wallace wrote:
>> -     /* When creating macvlans on top of other macvlans - use
>> +     /* When creating macvlans or macvtaps on top of other macvlans - use
>>        * the real device as the lowerdev.
>>        */
>> -     if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops) {
>> +     if (lowerdev->rtnl_link_ops == &macvlan_link_ops) {
>>               struct macvlan_dev *lowervlan = netdev_priv(lowerdev);
>>               lowerdev = lowervlan->lowerdev;
>>       }
>
> Perhaps we could use the helpers:
>
>         if (netif_is_macvlan(lowerdev))
>                 lowerdev = macvlan_dev_real_dev(lowerdev);
>
> to show more clearly what we are doing.
>
>                                                         Michal Kubecek
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html