netdev - Re: [PATCH] macvlan: Support creating macvtaps from macvlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131203082450.GA17839@unicorn.suse.cz>
Date:	Tue, 3 Dec 2013 09:24:51 +0100
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Kevin Wallace <kevin@...tabarf.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] macvlan: Support creating macvtaps from macvlans

On Mon, Dec 02, 2013 at 08:13:11PM -0800, Kevin Wallace wrote:
> -	/* When creating macvlans on top of other macvlans - use
> +	/* When creating macvlans or macvtaps on top of other macvlans - use
>  	 * the real device as the lowerdev.
>  	 */
> -	if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops) {
> +	if (lowerdev->rtnl_link_ops == &macvlan_link_ops) {
>  		struct macvlan_dev *lowervlan = netdev_priv(lowerdev);
>  		lowerdev = lowervlan->lowerdev;
>  	}

Perhaps we could use the helpers:

	if (netif_is_macvlan(lowerdev))
		lowerdev = macvlan_dev_real_dev(lowerdev);

to show more clearly what we are doing.

                                                        Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html