netdev - Re: [PATCH net-next] unix: convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Dec 2013 17:32:02 +0800
From:	Wang Weidong <wangweidong1@...wei.com>
To:	Daniel Borkmann <dborkman@...hat.com>
CC:	David Miller <davem@...emloft.net>, <edumazet@...gle.com>,
	<ebiederm@...ssion.com>, <gaofeng@...fujitsu.com>,
	<jacob.e.keller@...el.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] unix: convert printks to pr_<level>

On 2013/12/6 17:22, Daniel Borkmann wrote:
> On 12/06/2013 07:09 AM, Wang Weidong wrote:
>> use pr_<level> instead of printk(LEVEL)
>>
>> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
>> ---
>>   net/unix/af_unix.c |   10 ++++++----
>>   1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
>> index 4155ed3..ca98e61 100644
>> --- a/net/unix/af_unix.c
>> +++ b/net/unix/af_unix.c
>> @@ -80,6 +80,9 @@
>>    *          with BSD names.
>>    */
>>
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> +#define DEBUG
>> +
> 
> Why do you define DEBUG here ?
> 
I think the pr_debug != printk(KERN_DEBUG), equal when define DEBUG.

Regards.
Wang

>>   #include <linux/module.h>
>>   #include <linux/kernel.h>
>>   #include <linux/signal.h>
>> @@ -366,7 +369,7 @@ static void unix_sock_destructor(struct sock *sk)
>>       WARN_ON(!sk_unhashed(sk));
>>       WARN_ON(sk->sk_socket);
>>       if (!sock_flag(sk, SOCK_DEAD)) {
>> -        printk(KERN_INFO "Attempt to release alive unix socket: %p\n", sk);
>> +        pr_info("Attempt to release alive unix socket: %p\n", sk);
>>           return;
>>       }
>>
>> @@ -378,7 +381,7 @@ static void unix_sock_destructor(struct sock *sk)
>>       sock_prot_inuse_add(sock_net(sk), sk->sk_prot, -1);
>>       local_bh_enable();
>>   #ifdef UNIX_REFCNT_DEBUG
>> -    printk(KERN_DEBUG "UNIX %p is destroyed, %ld are still alive.\n", sk,
>> +    pr_debug("UNIX %p is destroyed, %ld are still alive.\n", sk,
>>           atomic_long_read(&unix_nr_socks));
>>   #endif
>>   }
>> @@ -2434,8 +2437,7 @@ static int __init af_unix_init(void)
>>
>>       rc = proto_register(&unix_proto, 1);
>>       if (rc != 0) {
>> -        printk(KERN_CRIT "%s: Cannot create unix_sock SLAB cache!\n",
>> -               __func__);
>> +        pr_crit("%s: Cannot create unix_sock SLAB cache!\n", __func__);
>>           goto out;
>>       }
>>
>>
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html