netdev - Re: [PATCH net-next] unix: convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Dec 2013 10:40:43 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Wang Weidong <wangweidong1@...wei.com>
CC:	David Miller <davem@...emloft.net>, edumazet@...gle.com,
	ebiederm@...ssion.com, gaofeng@...fujitsu.com,
	jacob.e.keller@...el.com, netdev@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH net-next] unix: convert printks to pr_<level>

On 12/06/2013 10:32 AM, Wang Weidong wrote:
> On 2013/12/6 17:22, Daniel Borkmann wrote:
>> On 12/06/2013 07:09 AM, Wang Weidong wrote:
>>> use pr_<level> instead of printk(LEVEL)
>>>
>>> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
>>> ---
>>>    net/unix/af_unix.c |   10 ++++++----
>>>    1 files changed, 6 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
>>> index 4155ed3..ca98e61 100644
>>> --- a/net/unix/af_unix.c
>>> +++ b/net/unix/af_unix.c
>>> @@ -80,6 +80,9 @@
>>>     *          with BSD names.
>>>     */
>>>
>>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>>> +#define DEBUG
>>> +
>>
>> Why do you define DEBUG here ?
>>
> I think the pr_debug != printk(KERN_DEBUG), equal when define DEBUG.

Ok, then please read Documentation/dynamic-debug-howto.txt

pr_debug() is part of the dynamic debugging framework and
can be enabled / disabled at runtime when configured. So
that define does not belong here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html