netdev - RE: [GIT PULL] xhci: Regression fix for 3.13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Dec 2013 17:19:33 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Sarah Sharp" <sarah.a.sharp@...ux.intel.com>,
	"Mark Lord" <mlord@...ox.com>
Cc:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: RE: [GIT PULL] xhci: Regression fix for 3.13.

> From: Sarah Sharp
> Sent: 06 December 2013 17:03
> To: Mark Lord
> Cc: Greg Kroah-Hartman; linux-usb@...r.kernel.org; David Laight; netdev@...r.kernel.org
> Subject: Re: [GIT PULL] xhci: Regression fix for 3.13.
> 
> On Fri, Dec 06, 2013 at 12:55:23AM -0500, Mark Lord wrote:
> > On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sharp wrote:
> > >> The following changes since commit c24cb6c8b501ebdf1aacec7960110a9741a45ced:
> > >>
> > >>   Merge tag 'fixes-for-v3.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into
> usb-linus (2013-11-27 09:49:03 -0800)
> > >>
> > >> are available in the git repository at:
> > >>
> > >>
> > >>   git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-linus-2013-12-02
> > >
> > > Pulled and pushed out, thanks.
> >
> > Did this commit make it into linux-3.12.3 ?
> >
> > I ask, because the NIC still locks up with that kernel,
> > and even with the patch I had been using from David Laight.
> >
> > Reverting the change that originally broke it still works though.
> > Could we please get this reverted until such time as a reworked
> > patch can be prepared for it?
> 
> Greg, can you please revert David's patch (commit 35773dac5f86 from your
> usb-linus branch)?
> 
> David said the patch fixed this lock up issue with his USB ethernet
> adapter, but Mark says it doesn't fix the issue.  The patch touches some
> hairy ring code in the xHCI driver, and I would rather not make any
> changes to that code unless we can prove there is an issue with that
> code.  We can always add the patch back later if it does turn out to fix
> an issue.

I thought Mark had said that my patch fixed things for him with the earlier
kernel.  It certainly makes a massive difference on my system.
And I ran with enough diagnostics to work out when the tx side stopped.
The last packet for which an ack was received was the one before the one
that straddled the ring end.

If you want to change the ax179 driver you need to stop it using
SG and segmentation offload.
The patch that mark is talking about isn't really the one that makes a difference.
I think it just forces the skb be linearised at that point. Which mostly
means that there won't be any fragments.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html