netdev - Re: [PATCH] bgmac: connect to PHY and make use of PHY device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A4B182.6070803@hauke-m.de>
Date:	Sun, 08 Dec 2013 18:50:58 +0100
From:	Hauke Mehrtens <hauke@...ke-m.de>
To:	Rafał Miłecki <zajec5@...il.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bgmac: connect to PHY and make use of PHY device

On 12/07/2013 12:53 AM, Rafał Miłecki wrote:
> We were already registering MDIO bus, but we were not connecting bgmac
> to the PHY. Add proper call and implement adjust link function to switch
> MAC into requested state.
> At the same time it's possible to drop our internal PHY management.
> This is a "standard" PHY, so the "Generic PHY" driver works perfectly
> fine with this. Don't duplicate the code.
> Finally make use of phy_ethtool_[gs]set functions instead implementing
> them from scratch.
> 
> This change was successfully tested on BCM5357. I was able to
> autonegotiate 1000Mb/s full duplex, as well as force any of the
> 10/100/1000 half/full modes.
> 
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
Nice patch.

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

> ---
>  drivers/net/ethernet/broadcom/bgmac.c |  190 +++++++++++----------------------
>  drivers/net/ethernet/broadcom/bgmac.h |   12 +--
>  2 files changed, 64 insertions(+), 138 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html