netdev - Re: [PATCH] bgmac: connect to PHY and make use of PHY device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131209.205947.2139145054909970576.davem@davemloft.net>
Date:	Mon, 09 Dec 2013 20:59:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	zajec5@...il.com, netdev@...r.kernel.org, hauke@...ke-m.de
Subject: Re: [PATCH] bgmac: connect to PHY and make use of PHY device

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 6 Dec 2013 16:59:26 -0800

> 2013/12/6 Rafa┅ Mi┅ecki <zajec5@...il.com>:
>> We were already registering MDIO bus, but we were not connecting bgmac
>> to the PHY. Add proper call and implement adjust link function to switch
>> MAC into requested state.
>> At the same time it's possible to drop our internal PHY management.
>> This is a "standard" PHY, so the "Generic PHY" driver works perfectly
>> fine with this. Don't duplicate the code.
>> Finally make use of phy_ethtool_[gs]set functions instead implementing
>> them from scratch.
>>
>> This change was successfully tested on BCM5357. I was able to
>> autonegotiate 1000Mb/s full duplex, as well as force any of the
>> 10/100/1000 half/full modes.
> 
> The diffstat is really impressive, nice job!
> 
>>
>> Signed-off-by: Rafa┅ Mi┅ecki <zajec5@...il.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html