netdev - Re: [net-next 06/13] bna: UDP RX Processing Improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131209.191755.1735369355458133155.davem@davemloft.net>
Date:	Mon, 09 Dec 2013 19:17:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rmody@...cade.com
Cc:	netdev@...r.kernel.org, adapter_linux_open_src_team@...cade.COM
Subject: Re: [net-next 06/13] bna: UDP RX Processing Improvements

From: Rasesh Mody <rmody@...cade.com>
Date: Sat, 7 Dec 2013 21:48:37 -0800

> @@ -233,13 +233,13 @@ struct bnad_tx_unmap {
>  struct bnad_rx_vector {
>  	DEFINE_DMA_UNMAP_ADDR(dma_addr);
>  	u32			len;
> -};
> +} __packed;

This is absolutely unacceptable, and at best not even mentioned in your
commit message.

There is no reason whatsoever to mark this structure as __packed.

I'm not applying this patch series, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html