netdev - RE: [net-next 06/13] bna: UDP RX Processing Improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86B69010DB7B@HQ1-EXCH01.corp.brocade.com>
Date:	Tue, 10 Dec 2013 16:05:46 -0800
From:	Rasesh Mody <rmody@...cade.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Adapter Linux Open SRC Team" 
	<adapter_linux_open_src_team@...cade.COM>
Subject: RE: [net-next 06/13] bna: UDP RX Processing Improvements

Hi Dave,

>From: David Miller [mailto:davem@...emloft.net]
>Sent: Monday, December 09, 2013 4:18 PM
>
>From: Rasesh Mody <rmody@...cade.com>
>Date: Sat, 7 Dec 2013 21:48:37 -0800
>
>> @@ -233,13 +233,13 @@ struct bnad_tx_unmap {  struct bnad_rx_vector {
>>  	DEFINE_DMA_UNMAP_ADDR(dma_addr);
>>  	u32			len;
>> -};
>> +} __packed;
>
>This is absolutely unacceptable, and at best not even mentioned in your
>commit message.
>
>There is no reason whatsoever to mark this structure as __packed.

By having the bnad_rx_unmap structure marked as __packed we were trying to
reduce the unmap_q size by 16K, __packed would ensure the RX unmap
structure of 40 bytes is packed to 32 bytes. This change was also captured
as a part of the commit message of patch #6 under change details.

We'll address your concern and resubmit the patches.

Thanks,
--Rasesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html