netdev - Re: [PATCH net-next] net: ovs: use CRC32 accelerated flow hash if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131210.143652.1279430126319061689.davem@davemloft.net>
Date:	Tue, 10 Dec 2013 14:36:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jesse@...ira.com
Cc:	ffusco@...hat.com, netdev@...r.kernel.org, dev@...nvswitch.org,
	dborkman@...hat.com, tgraf@...hat.com
Subject: Re: [PATCH net-next] net: ovs: use CRC32 accelerated flow hash if
 available

From: Jesse Gross <jesse@...ira.com>
Date: Tue, 10 Dec 2013 11:28:08 -0800

> I think this is definitely a good optimization to do given that so
> much of the work that OVS does is hashing. However, isn't there a
> library where there would be a more appropriate place to put this?

I also honestly don't see why we want to special case OVS at all
here.  This faster hashing would be useful for socket demux and
other locations in the kernel.

When I see changes like this my only reaction is "sad face".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html