netdev - Re: [PATCH net-next] net: ovs: use CRC32 accelerated flow hash if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Dec 2013 21:47:48 +0100
From:	Thomas Graf <tgraf@...hat.com>
To:	David Miller <davem@...emloft.net>, jesse@...ira.com
CC:	ffusco@...hat.com, netdev@...r.kernel.org, dev@...nvswitch.org,
	dborkman@...hat.com
Subject: Re: [PATCH net-next] net: ovs: use CRC32 accelerated flow hash if
 available

On 12/10/2013 08:36 PM, David Miller wrote:
> From: Jesse Gross <jesse@...ira.com>
> Date: Tue, 10 Dec 2013 11:28:08 -0800
>
>> I think this is definitely a good optimization to do given that so
>> much of the work that OVS does is hashing. However, isn't there a
>> library where there would be a more appropriate place to put this?
>
> I also honestly don't see why we want to special case OVS at all
> here.  This faster hashing would be useful for socket demux and
> other locations in the kernel.
>
> When I see changes like this my only reaction is "sad face".

We discussed this heavily and decided to go with the minimal approach
first to collect some feedback. We were not sure whether the runtime
check, function pointer and hardware dependencies are something other
subsystems that are less x86_64 centric would want to live with.

That said, we are _very_ willing to do the work and move it to lib/
to make it available to other consumers but one should be aware that
crc32 based hashes are not as generally usable as jhash.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html