netdev - RE: [Xen-devel] [PATCH net v5] xen-netback: fix fragment detection in checksum setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <52A821D6020000780010C279@nat28.tlf.novell.com>
Date:	Wed, 11 Dec 2013 07:27:02 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Paul Durrant" <Paul.Durrant@...rix.com>
Cc:	"David Vrabel" <david.vrabel@...rix.com>,
	"Ian Campbell" <Ian.Campbell@...rix.com>,
	"Wei Liu" <wei.liu2@...rix.com>,
	"Zoltan Kiss" <zoltan.kiss@...rix.com>,
	"David Miller" <davem@...emloft.net>,
	"xen-devel" <xen-devel@...ts.xenproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Xen-devel] [PATCH net v5] xen-netback: fix fragment
 detection in checksum setup

>>> On 10.12.13 at 18:29, Paul Durrant <Paul.Durrant@...rix.com> wrote:
>> Another question: Don't the skb_partial_csum_set() calls require
>> the respective pulls to have happened already?
>> 
> 
> I'm not aware of that requirement. There's no specific comment to that 
> effect that I can see and the code suggests that we only need to have pulled 
> up as far as the end of the checksum location itself.

Which we didn't - the previous pull only covered the IP header (and
in the IPv4 case even thereof only the basic, fixed size part).

Jan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html