netdev - Re: [PATCH net-next v3] ipv4: fix wildcard search with inet_confirm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131211.144910.1065298780981411778.davem@davemloft.net>
Date:	Wed, 11 Dec 2013 14:49:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	ja@....bg, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] ipv4: fix wildcard search with
 inet_confirm_addr()

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Tue, 10 Dec 2013 15:02:40 +0100

> 39a6d0630012 ("[NETNS]: Process inet_confirm_addr in the
> correct namespace."), the code supposes that it will never be NULL. This
> function is never called with in_dev == NULL, but it's exported and may be used
> by an external module.
> 
> Because this patch restore the ability to call inet_confirm_addr() with in_dev
> == NULL, I partially revert the above commit, as suggested by Julian.
> 
> CC: Julian Anastasov <ja@....bg>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Reviewed-by: Julian Anastasov <ja@....bg>

I personally think that we may be over analyzing this, because if some
external module actually cared, someone would have complained in the
last _5_ years as that's how long the new semantics have been in
place.

Nevertheless, passing in the network namespace explicitly is a bit
nicer than having special behavior for RT_SCOPE_LINE, thus I've
applied this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html