netdev - Re: [PATCH net-next v3 3/6] net_sched: mirred: remove action when the target device is gone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUYJgHB2aTv_4xGwnZfS+o8ZSbVpsisn7EpvzN21FymaA@mail.gmail.com>
Date:	Fri, 13 Dec 2013 10:52:10 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	David Laight <David.Laight@...lab.com>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v3 3/6] net_sched: mirred: remove action when the
 target device is gone

On Fri, Dec 13, 2013 at 4:12 AM, David Laight <David.Laight@...lab.com> wrote:
>> From: Jamal Hadi Salim
>> Sent: 13 December 2013 12:08
> ...
>> > -   int                     tcfm_ok_push;
>> > +   unsigned int            tcfm_ok_push:1;
>> > +   unsigned int            tcfm_bind:1;
>>
>> What has the above cleverness got to do with anything you intended?
>
> Not even 'cleverness'.
> Using byte-sized fields is enough to stop the structure growing.
> Bit fields are usually not a good idea at all.
>

They are both boolean, I think it is a waste to use 'int' for both of them.
I am not a fan of bit fields though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html