netdev - RE: [PATCH net-next v3 3/6] net_sched: mirred: remove action when the target device is gone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B748D@saturn3.aculab.com>
Date:	Fri, 13 Dec 2013 12:12:24 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Jamal Hadi Salim" <jhs@...atatu.com>,
	"Cong Wang" <xiyou.wangcong@...il.com>, <netdev@...r.kernel.org>
Cc:	"David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH net-next v3 3/6] net_sched: mirred: remove action when the target device is gone

> From: Jamal Hadi Salim
> Sent: 13 December 2013 12:08
...
> > -	int			tcfm_ok_push;
> > +	unsigned int		tcfm_ok_push:1;
> > +	unsigned int		tcfm_bind:1;
> 
> What has the above cleverness got to do with anything you intended?

Not even 'cleverness'.
Using byte-sized fields is enough to stop the structure growing.
Bit fields are usually not a good idea at all.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html