netdev - Re: [PATCH net-next] sch_tbf: add TBF_BURST/TBF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 10:11:59 +0800
From:	Yang Yingliang <yangyingliang@...wei.com>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] sch_tbf: add TBF_BURST/TBF_PBURST attribute

On 2013/12/13 17:50, Duan Jiong wrote:
> 于 2013年12月13日 17:41, Yang Yingliang 写道:
>> When we set burst to 1514 with low rate in userspace,
>> the kernel get a value of burst that less than 1514,
>> which doesn't work.
>>
>> Because it may make some loss when transform burst
>> to buffer in userspace. This makes burst lose some
>> bytes, when the kernel transform the buffer back to
>> burst.
>>
>> This patch adds two new attributes to support sending
>> burst/mtu to kernel directly to avoid the loss.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>> ---
[...]
>> diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
>> index 887e672..a746049 100644
>> --- a/net/sched/sch_tbf.c
>> +++ b/net/sched/sch_tbf.c
>> @@ -307,6 +307,8 @@ static const struct nla_policy tbf_policy[TCA_TBF_MAX + 1] = {
>>  	[TCA_TBF_PTAB]	= { .type = NLA_BINARY, .len = TC_RTAB_SIZE },
>>  	[TCA_TBF_RATE64]	= { .type = NLA_U64 },
>>  	[TCA_TBF_PRATE64]	= { .type = NLA_U64 },
>> +	[TCA_TBF_BURST]		= { .type = NLA_U32 },
> 
> This place should remove one tab.
> 
> Thanks,
>   Duan
> 

OK, thanks!



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html