netdev - Re: [PATCH net-next] net-ipv6: Fix alleged compiler warning in ipv6_exthdrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 10:30:26 +0800
From:	Jerry Chu <hkchu@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	hannes@...essinduktion.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-ipv6: Fix alleged compiler warning in ipv6_exthdrs_len()

On Mon, Dec 16, 2013 at 9:31 AM, David Miller <davem@...emloft.net> wrote:
> From: "H.K. Jerry Chu" <hkchu@...gle.com>
> Date: Sun, 15 Dec 2013 09:19:07 -0800
>
>> From: Jerry Chu <hkchu@...gle.com>
>>
>> It was reported that Commit 299603e8370a93dd5d8e8d800f0dff1ce2c53d36
>> ("net-gro: Prepare GRO stack for the upcoming tunneling support")
>> triggered a compiler warning in ipv6_exthdrs_len():
>>
>> net/ipv6/ip6_offload.c: In function ‘ipv6_gro_complete’:
>> net/ipv6/ip6_offload.c:178:24: warning: ‘optlen’ may be used uninitialized in this function [-Wmaybe-u
>>     opth = (void *)opth + optlen;
>>                       ^
>>     net/ipv6/ip6_offload.c:164:22: note: ‘optlen’ was declared here
>>     int len = 0, proto, optlen;
>>                         ^
>> Note that there was no real bug here - optlen was never uninitialized
>> before use. (Was the version of gcc I used smarter to not complain?)
>>
>> Reported-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
>> Signed-off-by: H.K. Jerry Chu <hkchu@...gle.com>
>
> What is this patch against?
>
> It gets rejects when I try to apply it both with Hannes's patch reverted
> and without it reverted.

It was against net-next of a few days old (and w/o Hannes's patch):

commit 68536053600425c24aba031c45f053d447eedd9c (netnext/master)
Author: Florent Fourcot <florent.fourcot@...t-bretagne.fr>
Date:   Thu Dec 12 17:07:58 2013 +0100

    ipv6: fix incorrect type in declaration

I just did a git pull and will submit one against the latest net-next.
(I did not see any conflict though. Not sure why you can't apply the patch.)

Jerry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html