netdev - RE: [PATCH] SCTP: Reduce log spamming for sctp setsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B749A@saturn3.aculab.com>
Date:	Mon, 16 Dec 2013 15:24:48 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Neil Horman" <nhorman@...driver.com>, <linux-sctp@...r.kernel.org>
Cc:	"Vlad Yasevich" <vyasevich@...il.com>,
	"David Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: RE: [PATCH] SCTP: Reduce log spamming for sctp setsockopt

> From: Neil Horman
> During a recent discussion regarding some sctp socket options, it was noted that
> we have several points at which we issue log warnings that can be flooded at an
> unbounded rate by any user.  Fix this by converting all the pr_warns in the
> sctp_setsockopt path to be pr_warn_ratelimited.
> 
> Note there are several debug level messages as well.  I'm leaving those alone,
> as, if you turn on pr_debug, you likely want lots of verbosity.
...
> -		pr_warn("Use of struct sctp_assoc_value in delayed_ack socket option deprecated\n");
> -		pr_warn("Use struct sctp_sack_info instead\n");
> +		pr_warn_ratelimited("Use of struct sctp_assoc_value in delayed_ack socket option
> deprecated\n");
> +		pr_warn_ratelimited("Use struct sctp_sack_info instead\n");

Do you need to send these as a single ratelimited message?

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html