netdev - Re: [PATCH] SCTP: Reduce log spamming for sctp setsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131216154413.GD19809@hmsreliant.think-freely.org>
Date:	Mon, 16 Dec 2013 10:44:13 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	linux-sctp@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] SCTP: Reduce log spamming for sctp setsockopt

On Mon, Dec 16, 2013 at 03:24:48PM -0000, David Laight wrote:
> > From: Neil Horman
> > During a recent discussion regarding some sctp socket options, it was noted that
> > we have several points at which we issue log warnings that can be flooded at an
> > unbounded rate by any user.  Fix this by converting all the pr_warns in the
> > sctp_setsockopt path to be pr_warn_ratelimited.
> > 
> > Note there are several debug level messages as well.  I'm leaving those alone,
> > as, if you turn on pr_debug, you likely want lots of verbosity.
> ...
> > -		pr_warn("Use of struct sctp_assoc_value in delayed_ack socket option deprecated\n");
> > -		pr_warn("Use struct sctp_sack_info instead\n");
> > +		pr_warn_ratelimited("Use of struct sctp_assoc_value in delayed_ack socket option
> > deprecated\n");
> > +		pr_warn_ratelimited("Use struct sctp_sack_info instead\n");
> 
> Do you need to send these as a single ratelimited message?
> 
> 	David
> 
Oh, good point, I'll clean that up.  Thanks!
Neil

> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html