netdev - Re: [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131218.165320.513139543099757450.davem@davemloft.net>
Date:	Wed, 18 Dec 2013 16:53:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	dingtianhong@...wei.com, andy@...yhouse.net, vfalico@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net 0/3] bonding: add port protection for
 bond_3ad_xxx_change()

From: Jay Vosburgh <fubar@...ibm.com>
Date: Fri, 13 Dec 2013 14:26:02 -0800

> Ding Tianhong <dingtianhong@...wei.com> wrote:
> 
>>Jay Vosburgh said that the bond_3ad_adapter_speed_changed and 
>>bond_3ad_adapter_duplex_changed is called with RTNL only, and
>>the functions will modify the port's information with no further
>>locking, they will not mutex against bond state machine and
>>incoming LACPDU which do not hold RTNL, So I add port lock to
>>protect the port information.
>>
>>But they are not critical bugs, they exist since day one, and till
>>now they have never been hit and reported, because change for speed
>>and duplex is very rare, and will not occur critical problem.
>>
>>The comments in the function is very old, cleanup the comments together.
> 
> 	For entire series:
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html