netdev - Re: [PATCH] net: fec: fix potential use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387484318.19078.377.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 19 Dec 2013 12:18:38 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Frank Li <lznuaa@...il.com>
Cc:	Richard Cochran <richardcochran@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Frank Li <Frank.Li@...escale.com>
Subject: Re: [PATCH] net: fec: fix potential use after free

On Thu, 2013-12-19 at 14:05 -0600, Frank Li wrote:

> I think It is not related with hw_lock.  After trigger transfer,
> there are possibility that tx completed immediately and irq handle
> will free skb.

Well, before the de5fb0a05348 commit, tx completion and start_xmit()
could not run in //

So hw_lock was effectively preventing the issue.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html