netdev - RE: [PATCH] net: fec: fix potential use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a8a43fd218241a29be996e8bc62e95f@BLUPR03MB486.namprd03.prod.outlook.com>
Date:	Thu, 19 Dec 2013 20:30:14 +0000
From:	"Frank.Li@...escale.com" <Frank.Li@...escale.com>
To:	Eric Dumazet <eric.dumazet@...il.com>, Frank Li <lznuaa@...il.com>
CC:	Richard Cochran <richardcochran@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: fec: fix potential use after free

> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Thursday, December 19, 2013 2:19 PM
> To: Frank Li
> Cc: Richard Cochran; David Miller; netdev; Li Frank-B20596
> Subject: Re: [PATCH] net: fec: fix potential use after free
> 
> On Thu, 2013-12-19 at 14:05 -0600, Frank Li wrote:
> 
> > I think It is not related with hw_lock.  After trigger transfer, there
> > are possibility that tx completed immediately and irq handle will free
> > skb.
> 
> Well, before the de5fb0a05348 commit, tx completion and start_xmit() could not
> run in //
> 
> So hw_lock was effectively preventing the issue.
> 	

Yes, IRQ handle will wait for spin_lock.