netdev - Re: [PATCH 2/2] net_sched: optimize tcf_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B434A9.9070408@mojatatu.com>
Date:	Fri, 20 Dec 2013 07:14:33 -0500
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>
CC:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/2] net_sched: optimize tcf_match_indev()

On 12/20/13 03:12, Cong Wang wrote:
> On Thu, Dec 19, 2013 at 10:54 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> On Thu, 2013-12-19 at 22:36 -0800, Cong Wang wrote:
>>
>>> Hmm, off-by-one error, stupid me.
>>
>> There is something else.
>>
>> Its late here, I'll let you find and fix the problems.
>>
>
> I just sent a fix for the problem I see, not sure it fixes
> the bug you reported too.
>
> I will test it as a module tomorrow, if you don't send a fix
> before that.
>

Very impressive catch Eric. I would have 100% caught this with testing
(but you caught it by inspecting code!).
A simple test that dumps all the actions of a specific type would do.
Example in your case, Cong:
tc actions ls action mirred

[I dont want to sound passive aggressive (a Canadian right, of course),
but this is why i get nervous about big changes like these which dont 
undergo more testing time.]

cheers,
jamal


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html