netdev - Re: [PATCH 2/2] net_sched: optimize tcf_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWz0NP_6vtYhHSSDW1p3HdALoiNm7JkwL=1-XErHOZ14w@mail.gmail.com>
Date:	Fri, 20 Dec 2013 10:55:34 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/2] net_sched: optimize tcf_match_indev()

On Fri, Dec 20, 2013 at 4:14 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> Very impressive catch Eric. I would have 100% caught this with testing
> (but you caught it by inspecting code!).
> A simple test that dumps all the actions of a specific type would do.
> Example in your case, Cong:
> tc actions ls action mirred
>

Are you sure?? It is in my test case right after David merged it,
I still don't see any bug it reports so far.

For completeness, here is my one of test cases:

ip li add dev dummy0 type dummy
ip li add dev dummy1 type dummy
ip li add dev dummy2 type dummy
tc qdisc del dev $1 ingress
tc qdisc add dev $1 ingress
tc filter add dev $1 parent ffff: protocol ip u32 match ip protocol 1
0xff action mirred egress mirror dev dummy0 action mirred egress
mirror dev dummy1
tc filter add dev $1 parent ffff: protocol ip u32 match ip protocol 1
0xff action mirred egress mirror dev dummy0 action mirred egress
mirror dev dummy2
tc filter show dev $1 parent ffff: && tc action ls action mirred
ip li del dummy0
tc filter show dev $1 parent ffff: && tc action ls action mirred
ip li del dummy1
tc filter show dev $1 parent ffff: && tc action ls action mirred
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html