netdev - Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131220.164915.1182500137355120095.davem@davemloft.net>
Date:	Fri, 20 Dec 2013 16:49:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	or.gerlitz@...il.com
Cc:	jeffrey.t.kirsher@...el.com, joseph.gasparakis@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's

From: Or Gerlitz <or.gerlitz@...il.com>
Date: Fri, 20 Dec 2013 23:06:06 +0200

> On Fri, Dec 20, 2013 at 8:21 PM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
>> @@ -244,6 +244,7 @@ config IXGBEVF
>>  config I40E
>>         tristate "Intel(R) Ethernet Controller XL710 Family support"
>>         depends on PCI
>> +       depends on VXLAN || !VXLAN

I definitely want a clear detailed explanation for this gross
dependency.

>> +       i40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_add_udp_tunnel);
>> +
>> +       cmd->udp_port = cpu_to_le16(udp_port);
>> +       cmd->header_len = header_len;
>> +       cmd->protocol_index = protocol_index;
>> +
>> +       status = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);
> 
> so i40e_asq_send_command is called with a spinlock held or under
> rcu_read_lock from the vxlan driver code but might sleep, as it takes
> a mutex, seems problematic.

Indeed this looks like a bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html