netdev - Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131220.204105.425672139698438176.davem@davemloft.net>
Date:	Fri, 20 Dec 2013 20:41:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joseph.gasparakis@...el.com
Cc:	or.gerlitz@...il.com, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's

From: Joseph Gasparakis <joseph.gasparakis@...el.com>
Date: Fri, 20 Dec 2013 15:25:44 -0800 (PST)

> Right now the code in vxlan.h is:
> 
> #if IS_ENABLED(CONFIG_VXLAN)
> void vxlan_get_rx_port(struct net_device *netdev);
> #else
> static inline void vxlan_get_rx_port(struct net_device *netdev)
> {
> }
> #endif
> 
> so the function can be called from drivers whether vxlan is enabled in 
> .config or not. However, the "depends on VXLAN || !VXLAN" is needed when 
> the driver is compiled as a built-in, otherwise we get an undefined 
> reference for the above function. If this is not the right way to fix the 
> dependency please let me know and I will fix it accordingly.

Ok, can you write this with the more canonical:

	(X || X=n)

That's how we write it out to handle the same issue with
IPV6.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html