netdev - Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.03.1312201814240.7372@intel.com>
Date:	Fri, 20 Dec 2013 18:14:46 -0800 (PST)
From:	Joseph Gasparakis <joseph.gasparakis@...el.com>
To:	David Miller <davem@...emloft.net>
cc:	"Gasparakis, Joseph" <joseph.gasparakis@...el.com>,
	"or.gerlitz@...il.com" <or.gerlitz@...il.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's



On Fri, 20 Dec 2013, David Miller wrote:

> From: Joseph Gasparakis <joseph.gasparakis@...el.com>
> Date: Fri, 20 Dec 2013 15:25:44 -0800 (PST)
> 
> > Right now the code in vxlan.h is:
> > 
> > #if IS_ENABLED(CONFIG_VXLAN)
> > void vxlan_get_rx_port(struct net_device *netdev);
> > #else
> > static inline void vxlan_get_rx_port(struct net_device *netdev)
> > {
> > }
> > #endif
> > 
> > so the function can be called from drivers whether vxlan is enabled in 
> > .config or not. However, the "depends on VXLAN || !VXLAN" is needed when 
> > the driver is compiled as a built-in, otherwise we get an undefined 
> > reference for the above function. If this is not the right way to fix the 
> > dependency please let me know and I will fix it accordingly.
> 
> Ok, can you write this with the more canonical:
> 
> 	(X || X=n)
> 
> That's how we write it out to handle the same issue with
> IPV6.
> 
> Thanks.

Will do. Thanks.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html