netdev - Re: [PATCH net-next 1/3] bonding: add option lp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B52E99.7070809@huawei.com>
Date:	Sat, 21 Dec 2013 14:00:57 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>,
	Veaceslav Falico <vfalico@...hat.com>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] bonding: add option lp_interval for loading
 module

On 2013/12/20 21:42, Sergei Shtylyov wrote:
> Hello.
> 
> On 20-12-2013 9:10, Ding Tianhong wrote:
> 
>> The bond driver could set the lp_interval when loading module.
> 
>> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
>> ---
>>   drivers/net/bonding/bond_main.c | 15 +++++++++++++--
>>   1 file changed, 13 insertions(+), 2 deletions(-)
> 
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index c0456cc..368f7e4 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
> [...]
>> @@ -4271,6 +4276,12 @@ static int bond_check_params(struct bond_params *params)
>>           fail_over_mac_value = BOND_FOM_NONE;
>>       }
>>
>> +    if (lp_interval == 0) {
>> +        pr_warning("Warning: ip_interval must be between 1 and %d, so it was reset to %d\n",
>> +            INT_MAX, BOND_ALB_DEFAULT_LP_INTERVAL);
> 
>    The continuation line should be aligned under ", according to the networking coding style.
> 
> WBR, Sergei
> 
> 

Ok, I will fix it, thanks.

Regards
Ding

> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html