netdev - Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131222.185027.572777902017063381.davem@davemloft.net>
Date:	Sun, 22 Dec 2013 18:50:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	antonio@...hcoding.com
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	mareklindner@...mailbox.ch
Subject: Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally
 delivered skb

From: Antonio Quartulli <antonio@...hcoding.com>
Date: Thu, 19 Dec 2013 01:15:27 +0100

> If an interface enslaved into batman-adv is a bridge (or a
> virtual interface built on top of a bridge) the nf_bridge
> member of the skbs reaching the soft-interface is filled
> with the state about "netfilter bridge" operations.
> 
> Then, if one of such skbs is locally delivered, the nf_bridge
> member should be cleaned up to avoid that the old state
> could mess up with other "netfilter bridge" operations when
> entering a second bridge.
> This is needed because batman-adv is an encapsulation
> protocol.
> 
> However at the moment skb->nf_bridge is not released at all
> leading to bogus "netfilter bridge" behaviours.
> Fix this by releasing skb->nf_bridge before an skb gets
> delivered to the upper layer in interface_rx().
> 
> Signed-off-by: Antonio Quartulli <antonio@...hcoding.com>
> Signed-off-by: Marek Lindner <mareklindner@...mailbox.ch>

See nf_reset() and skb_scrub_packet().  Do not reinvent the
wheel.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html