netdev - Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B77F9E.8040201@meshcoding.com>
Date:	Mon, 23 Dec 2013 01:11:10 +0100
From:	Antonio Quartulli <antonio@...hcoding.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	mareklindner@...mailbox.ch
Subject: Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered
 skb

On 23/12/13 00:50, David Miller wrote:
> 
> See nf_reset() and skb_scrub_packet().  Do not reinvent the
> wheel.
> 

Hello David,

after some discussion[1] the suggestion was to keep the behaviour as
less intrusive as possible, thus I avoided any nf_reset() (and similar)
and I directly wrote my function that calls nf_bridge_put() only.

Do you think it is safe to use nf_reset() directly?
Pablo was worried about "strange" user configurations that may break
because of this.
(Even if somebody may argue that in this case user configurations are
probably broken, not the kernel :-) ).

Regards,

[1] http://thread.gmane.org/gmane.linux.network/286965/focus=287502

-- 
Antonio Quartulli

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)