lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20131222.191400.620087948725635345.davem@davemloft.net>
Date:	Sun, 22 Dec 2013 19:14:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	ogerlitz@...lanox.com, netdev@...r.kernel.org, amirv@...lanox.com,
	yanb@...lanox.com, ast@...mgrid.com
Subject: Re: [PATCH net-next V2 2/2] net/mlx4_en: Add netdev support for
 TCP/IP offloads of vxlan tunneling

From: Joe Perches <joe@...ches.com>
Date: Sun, 22 Dec 2013 15:32:39 -0800

> On Sun, 2013-12-22 at 18:12 -0500, David Miller wrote:
>> From: Or Gerlitz <ogerlitz@...lanox.com>
>> Date: Sun, 22 Dec 2013 17:26:12 +0200
>> 
>> > +	if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> > +	if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> > +	if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> > +	    (mdev->dev->caps.tunnel_offload_mode ==  MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> > +	if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> 
>> Way too many parenthesis, this isn't LISP :-)
> 
> Is patchwork stuttering?

I edited it, I'm quoting all of the lines in your patch that add the
"too many parenthsis" problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ