netdev - Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Dec 2013 06:52:53 -0800
From:	Joe Perches <joe@...ches.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, amirv@...lanox.com,
	yanb@...lanox.com, ast@...mgrid.com,
	Matan Barak <matanb@...lanox.com>
Subject: Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for
 TCP/IP offloads of vxlan tunneling

On Sun, 2013-12-22 at 16:45 +0200, Or Gerlitz wrote:
> On 22/12/2013 16:19, Joe Perches wrote:
> > On Sun, 2013-12-22 at 16:00 +0200, Or Gerlitz wrote:
> > trivia:
[]
> >> @@ -68,6 +68,12 @@ void mlx4_en_fill_qp_context(struct mlx4_en_priv *priv, int size, int stride,
> >>   	context->db_rec_addr = cpu_to_be64(priv->res.db.dma << 2);
> >>   	if (!(dev->features & NETIF_F_HW_VLAN_CTAG_RX))
> >>   		context->param3 |= cpu_to_be32(1 << 30);
> >> +
> >> +	if (!is_tx && !rss &&
> >> +	    (mdev->dev->caps.tunnel_offload_mode ==  MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
> >> +		en_dbg(HW, priv, "Setting RX qp %x tunnel mode to RX tunneled & non-tunneled\n", qpn);
> >> +		context->srqn |= cpu_to_be32(7 << 28); /* this fills bits 30:28 */
> > Is that bit setting 0 based or 1 based?
> 
> 1 based, any issue with that?

No, but if it's 1 based, doesn't this fill bits 31:29 ?

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html