netdev - Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B6FCF7.5010205@mellanox.com>
Date:	Sun, 22 Dec 2013 16:53:43 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Joe Perches <joe@...ches.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<amirv@...lanox.com>, <yanb@...lanox.com>, <ast@...mgrid.com>
Subject: Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP
 offloads of vxlan tunneling

On 22/12/2013 16:19, Joe Perches wrote:
>> >+	if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> >+		dev->hw_enc_features = NETIF_F_SG | NETIF_F_IP_CSUM |
>> >+					NETIF_F_RXCSUM | NETIF_F_TSO |
>> >+					NETIF_F_GSO_UDP_TUNNEL;
>> >+		dev->hw_features |= NETIF_F_GSO_UDP_TUNNEL;
>> >+		dev->features    |= NETIF_F_GSO_UDP_TUNNEL;
> Perhaps hw_enc_features should be |= as well.
> NETIF_F_SG is set in register_netdevice() for hw_enc_features.
>

OK, I'll do that, thanks for spotting this over.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html