netdev - Re: [PATCH net-next 4/6] r8152: add rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131227.122813.901851776030758668.davem@davemloft.net>
Date:	Fri, 27 Dec 2013 12:28:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hayeswang@...ltek.com
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next 4/6] r8152: add rtl_ops

From: Hayes Wang <hayeswang@...ltek.com>
Date: Fri, 27 Dec 2013 10:34:08 +0800

>  
> +static int rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id)
 ...
>  
> +	if (rtl_ops_init(tp, id)) {
> +		netif_err(tp, probe, netdev, "Unknown Device");
> +		return -ENODEV;

You're completely ignoring the error code returned from rtl_ops_init()
(which, as an aside, uses -EFAULT which doesn't seem all that
appropriate).

You might as well have rtl_ops_init() return a boolean.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html