netdev - Re: [PATCH net-next 3/6] r8152: change some definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131227185755.GA29006@electric-eye.fr.zoreil.com>
Date:	Fri, 27 Dec 2013 19:57:55 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Hayes Wang <hayeswang@...ltek.com>
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next 3/6] r8152: change some definitions

Hayes Wang <hayeswang@...ltek.com> :
[...]
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index b8bc3eb..a8ea848 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
[...]
> @@ -274,6 +274,9 @@ enum rtl_register_content {
>  #define RTL8152_MAX_TX		10
>  #define RTL8152_MAX_RX		10
>  #define INTBUFSIZE		2
> +#define CRC_SIZE		4

ETH_FCS_LEN ?

[...]
> @@ -1215,7 +1220,7 @@ static void rx_bottom(struct r8152 *tp)
>  
>  			stats = rtl8152_get_stats(netdev);
>  
> -			pkt_len -= 4; /* CRC */
> +			pkt_len -= CRC_SIZE; /* CRC */
>  			rx_data += sizeof(struct rx_desc);

Nit: you may remove the trailing "/* CRC */" in the same patch.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html